Fix order filter date #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernicPanel
force-pushed
the
fix-order-filter-date
branch
2 times, most recently
from
76520db to
a1fe7ed
Compare
jonathanreveille
approved these changes
Dec 23, 2024
jbpenrath
approved these changes
Jan 6, 2025
Django is deprecating datetime_safe usage.
Order filtering is matching created_on date exactly, which only matches times at 0:00, as query parameter only contains a date.
kernicPanel
force-pushed
the
fix-order-filter-date
branch
from
a1fe7ed to
2f33ac3
Compare
kernicPanel
force-pushed
the
fix-order-filter-date
branch
from
33222f1 to
2f33ac3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
A test about order filtering on creation date was flaky, it was about results ordering.
While digging for a fix, it appears that when we filter on a date, only orders created at 0:00 were found.
Also, a Django deprecation about datetime_safe was raised.
Proposal